Issue 65853002: Stop leaking a CERTCertificate* during SSL renegotiation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 65853002: Stop leaking a CERTCertificate* during SSL renegotiation (Closed)

Created:
7 years, 1 month ago by Ryan Sleevi

Modified:
7 years, 1 month ago

Reviewers:
agl, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Stop leaking a CERTCertificate* during SSL renegotiation BUG=316407 R=agl Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233879

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/socket/ssl_client_socket_nss.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Ryan Sleevi

agl: stampy stampy? SSL_PeerCertificate uses CERT_DupCertificate, as seen at http://mxr.mozilla.org/nss/source/lib/ssl/sslauth.c#14

7 years, 1 month ago (2013-11-08 00:00:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/65853002/1

7 years, 1 month ago (2013-11-08 00:10:25 UTC) #3

Message was sent while issue was closed.

Patch set 1 LGTM. Sorry about the memory leak.