Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 658523007: history: fix focus outline for [ All | Week | Month ] controls. (Closed)

Created:
6 years, 2 months ago by Dan Beam
Modified:
6 years, 2 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

history: fix focus outline for [ All | Week | Month ] controls. R=estade@chromium.org BUG=422851 Committed: https://crrev.com/de09561ee432f01c1ae3449a9bc44b3b7cfd4d51 Cr-Commit-Position: refs/heads/master@{#299814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/history/history.css View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Dan Beam
6 years, 2 months ago (2014-10-15 03:32:21 UTC) #1
Evan Stade
what about for people who are using an external keyboard or a trackball like they ...
6 years, 2 months ago (2014-10-15 21:53:57 UTC) #2
Dan Beam
did you mean for this comment to go on: https://codereview.chromium.org/657493003/ ?
6 years, 2 months ago (2014-10-15 21:54:45 UTC) #3
Evan Stade
On 2014/10/15 21:54:45, Dan Beam wrote: > did you mean for this comment to go ...
6 years, 2 months ago (2014-10-15 21:55:58 UTC) #4
Dan Beam
requested screenshots: http://imgur.com/a/eTBFG
6 years, 2 months ago (2014-10-15 22:45:53 UTC) #5
Evan Stade
lgtm
6 years, 2 months ago (2014-10-16 00:25:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658523007/1
6 years, 2 months ago (2014-10-16 01:12:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 01:51:19 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 01:52:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de09561ee432f01c1ae3449a9bc44b3b7cfd4d51
Cr-Commit-Position: refs/heads/master@{#299814}

Powered by Google App Engine
This is Rietveld 408576698