Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 658523002: Simple typing of machine operators. (Closed)

Created:
6 years, 2 months ago by neis
Modified:
6 years, 2 months ago
Reviewers:
rossberg
Project:
v8
Visibility:
Public.

Description

Simple typing of machine operators. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24601

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -5 lines) Patch
M src/compiler/typer.cc View 1 1 chunk +314 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
neis
6 years, 2 months ago (2014-10-14 11:15:13 UTC) #1
rossberg
LGTM modulo comments https://codereview.chromium.org/658523002/diff/1/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/658523002/diff/1/src/compiler/typer.cc#newcode915 src/compiler/typer.cc:915: return Bounds(Type::Integral32()); I believe this actually ...
6 years, 2 months ago (2014-10-14 12:20:06 UTC) #2
neis1
https://codereview.chromium.org/658523002/diff/1/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/658523002/diff/1/src/compiler/typer.cc#newcode915 src/compiler/typer.cc:915: return Bounds(Type::Integral32()); On 2014/10/14 12:20:06, rossberg wrote: > I ...
6 years, 2 months ago (2014-10-14 12:26:57 UTC) #3
neis
6 years, 2 months ago (2014-10-14 12:27:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24601 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698