Use C++11 features in ContentSecurityPolicy

Use C++11 features in ContentSecurityPolicy

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183863

[kenneth.r.christiansen, 2014-10-16 15:59:00]

kenneth.r.christiansen@intel.com changed reviewers:
+ mkwst@chromium.org

[Mike West, 2014-10-16 19:35:07]

Thanks for taking a look at this! A few small comments.

https://codereview.chromium.org/658513003/diff/20001/Source/core/frame/csp/Co...
File Source/core/frame/csp/ContentSecurityPolicy.cpp (right):

https://codereview.chromium.org/658513003/diff/20001/Source/core/frame/csp/Co...
Source/core/frame/csp/ContentSecurityPolicy.cpp:577: for (const auto&
cspDirective : m_policies) {
Nit: Here, and pretty much everywhere else, s/cspDirective/policy/. m_policies
is a list of policies, each of which contains a list of directives. :)

https://codereview.chromium.org/658513003/diff/20001/Source/core/frame/csp/Co...
Source/core/frame/csp/ContentSecurityPolicy.cpp:713:
PingLoader::sendViolationReport(frame, completeURL(endpoint), report,
PingLoader::ContentSecurityPolicyViolationReport);
Oops. Please s/completeURL(endpoint)/url/g in this line. It should be sending
the violation report to the result of #712.

[kenneth.christiansen, 2014-10-16 22:15:38]

On 2014/10/16 at 19:35:07, mkwst wrote:
> Thanks for taking a look at this! A few small comments.
> 
>
https://codereview.chromium.org/658513003/diff/20001/Source/core/frame/csp/Co...
> File Source/core/frame/csp/ContentSecurityPolicy.cpp (right):
> 
>
https://codereview.chromium.org/658513003/diff/20001/Source/core/frame/csp/Co...
> Source/core/frame/csp/ContentSecurityPolicy.cpp:577: for (const auto&
cspDirective : m_policies) {
> Nit: Here, and pretty much everywhere else, s/cspDirective/policy/. m_policies
is a list of policies, each of which contains a list of directives. :)
> 
>
https://codereview.chromium.org/658513003/diff/20001/Source/core/frame/csp/Co...
> Source/core/frame/csp/ContentSecurityPolicy.cpp:713:
PingLoader::sendViolationReport(frame, completeURL(endpoint), report,
PingLoader::ContentSecurityPolicyViolationReport);
> Oops. Please s/completeURL(endpoint)/url/g in this line. It should be sending
the violation report to the result of #712.

Fixed

[Mike West, 2014-10-17 07:55:53]

LGTM, thanks.

[kenneth.r.christiansen, 2014-10-17 08:25:14]

The CQ bit was checked by kenneth.r.christiansen@intel.com

[commit-bot: I haz the power, 2014-10-17 08:25:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/658513003/40001

[commit-bot: I haz the power, 2014-10-17 08:39:10]

Committed patchset #3 (id:40001) as 183863