Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 658513002: Fix documentation in policy templates (Closed)

Created:
6 years, 2 months ago by kaliamoorthi
Modified:
6 years, 2 months ago
CC:
chromium-reviews, joaodasilva+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix documentation in policy templates Fix documentation of RegisteredProtocolHandlers policy in policy_templates BUG=419755 Committed: https://crrev.com/a639a5217132e6dcfb8b892e3878d7d32d9e4750 Cr-Commit-Position: refs/heads/master@{#299452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/policy/resources/policy_templates.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
kaliamoorthi
PTAL
6 years, 2 months ago (2014-10-14 08:34:06 UTC) #2
kaliamoorthi
PTAL
6 years, 2 months ago (2014-10-14 08:41:22 UTC) #4
Joao da Silva
lgtm Nice find. Ideally we would have a presubmit check that the example values conform ...
6 years, 2 months ago (2014-10-14 08:41:54 UTC) #6
kaliamoorthi
On 2014/10/14 08:41:54, Joao da Silva wrote: > lgtm > > Nice find. Ideally we ...
6 years, 2 months ago (2014-10-14 08:42:59 UTC) #7
Joao da Silva
(just realized that the review wasn't sent to me; I just got it via the ...
6 years, 2 months ago (2014-10-14 08:43:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658513002/1
6 years, 2 months ago (2014-10-14 08:44:01 UTC) #10
kaliamoorthi
On 2014/10/14 08:43:34, Joao da Silva wrote: > (just realized that the review wasn't sent ...
6 years, 2 months ago (2014-10-14 08:44:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 09:46:46 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 09:47:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a639a5217132e6dcfb8b892e3878d7d32d9e4750
Cr-Commit-Position: refs/heads/master@{#299452}

Powered by Google App Engine
This is Rietveld 408576698