Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 658423002: Unship ES6 iteration and unscopables on 3.28 (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
Reviewers:
danno, rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Unship ES6 iteration and unscopables on 3.28 BUG=chromium:409858 R=danno@chromium.org,rossberg@chromium.org LOG=y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1532 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M src/array.js View 1 chunk +0 lines, -14 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/parser.cc View 3 chunks +4 lines, -1 line 0 comments Download
M src/preparser.h View 4 chunks +4 lines, -0 lines 0 comments Download
M src/preparser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/symbol.js View 1 chunk +2 lines, -2 lines 0 comments Download
A src/unscopables.js View 1 chunk +39 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M test/cctest/test-unscopables-hidden-prototype.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/builtins.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/es6/array-iterator.js View 1 chunk +0 lines, -252 lines 0 comments Download
D test/mjsunit/es6/iteration-semantics.js View 1 chunk +0 lines, -336 lines 0 comments Download
D test/mjsunit/es6/iteration-syntax.js View 1 chunk +0 lines, -70 lines 0 comments Download
D test/mjsunit/es6/regress/regress-crbug-248025.js View 1 chunk +0 lines, -38 lines 0 comments Download
D test/mjsunit/es6/string-iterator.js View 1 chunk +0 lines, -89 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/es6/typed-array-iterator.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/mjsunit/es6/unscopables.js View 1 chunk +0 lines, -664 lines 0 comments Download
A + test/mjsunit/harmony/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/generators-iteration.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/harmony/iteration-semantics.js View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/harmony/iteration-syntax.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/harmony/regress/regress-crbug-248025.js View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/string-iterator.js View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/typed-array-iterator.js View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/unscopables.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-17 15:24:09 UTC) #1
jochen (gone - plz use gerrit)
it apparently breaks OWA (see the referenced bug)
6 years, 2 months ago (2014-10-17 15:38:06 UTC) #2
wingo (chromium)
On 2014/10/17 15:38:06, jochen wrote: > it apparently breaks OWA (see the referenced bug) Another ...
6 years, 2 months ago (2014-10-17 15:50:08 UTC) #3
arv (Not doing code reviews)
On 2014/10/17 15:50:08, wingo (chromium) wrote: > On 2014/10/17 15:38:06, jochen wrote: > > it ...
6 years, 2 months ago (2014-10-17 16:34:46 UTC) #4
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-20 13:21:21 UTC) #5
not needed... closing

Powered by Google App Engine
This is Rietveld 408576698