Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 658393002: Improve the documentation for the ManagedBookmarks policy. (Closed)

Created:
6 years, 2 months ago by Joao da Silva
Modified:
6 years, 2 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, joaodasilva+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Improve the documentation for the ManagedBookmarks policy. This change expands the example policy value to demonstrate how bookmark folders can be configured. BUG=424181 Committed: https://crrev.com/fa9792b39eab80dfa1c98e3d199fb550c535169f Cr-Commit-Position: refs/heads/master@{#300457}

Patch Set 1 #

Total comments: 4

Patch Set 2 : updated docs #

Patch Set 3 : fixed docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M components/policy/resources/policy_templates.json View 1 2 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Joao da Silva
PTAL, thanks!
6 years, 2 months ago (2014-10-17 14:41:48 UTC) #2
Thiemo Nagel
https://codereview.chromium.org/658393002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/658393002/diff/1/components/policy/resources/policy_templates.json#newcode6520 components/policy/resources/policy_templates.json:6520: "url": "google.com" I'd suggest to add scheme and directory ...
6 years, 2 months ago (2014-10-20 09:05:39 UTC) #3
Joao da Silva
https://codereview.chromium.org/658393002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/658393002/diff/1/components/policy/resources/policy_templates.json#newcode6520 components/policy/resources/policy_templates.json:6520: "url": "google.com" On 2014/10/20 09:05:38, Thiemo Nagel wrote: > ...
6 years, 2 months ago (2014-10-20 09:21:39 UTC) #4
Thiemo Nagel
https://codereview.chromium.org/658393002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/658393002/diff/1/components/policy/resources/policy_templates.json#newcode6520 components/policy/resources/policy_templates.json:6520: "url": "google.com" > The URLs in this policy work ...
6 years, 2 months ago (2014-10-20 09:57:07 UTC) #5
Joao da Silva
PTAL https://codereview.chromium.org/658393002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/658393002/diff/1/components/policy/resources/policy_templates.json#newcode6520 components/policy/resources/policy_templates.json:6520: "url": "google.com" On 2014/10/20 09:57:07, Thiemo Nagel wrote: ...
6 years, 2 months ago (2014-10-20 14:22:14 UTC) #6
Thiemo Nagel
LGTM.
6 years, 2 months ago (2014-10-20 16:17:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658393002/40001
6 years, 2 months ago (2014-10-21 08:10:08 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-21 11:27:04 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 11:27:57 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fa9792b39eab80dfa1c98e3d199fb550c535169f
Cr-Commit-Position: refs/heads/master@{#300457}

Powered by Google App Engine
This is Rietveld 408576698