Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/BUILD.gn

Issue 658383003: Componentize Constrained Window Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: gn Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/chrome_browser_ui.gypi ('K') | « chrome/chrome_tests_unit.gypi ('k') | components/OWNERS » ('j') | components/OWNERS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index 36b19c5c9e6ea8894202aafa6c2b04d8c6c2f2d1..773a3bd1729758125d69a1d6b5955ff7453093a7 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -193,6 +193,12 @@ group("all_components") {
"//components/storage_monitor",
]
}
+
+ if (toolkit_views) {
+ deps += [
+ "//components/constrained_window",
+ ]
+ }
}
# TODO(GYP) enable when it links.
@@ -219,6 +225,7 @@ test("components_unittests") {
"//components/captive_portal:unit_tests",
"//components/cloud_devices/common:unit_tests",
"//components/component_updater:unit_tests",
+ "//components/constrained_window:unit_tests",
msw 2014/10/22 21:32:43 Does this need to be contingent on |toolkit_views|
oshima 2014/10/22 22:39:08 Done.
"//components/content_settings/core/browser:unit_tests",
"//components/content_settings/core/common:unit_tests",
"//components/crx_file:unit_tests",
« chrome/chrome_browser_ui.gypi ('K') | « chrome/chrome_tests_unit.gypi ('k') | components/OWNERS » ('j') | components/OWNERS » ('J')

Powered by Google App Engine
This is Rietveld 408576698