Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/hung_renderer_view.cc

Issue 658383003: Componentize Constrained Window Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: gn Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/chrome_constrained_window_views_client.cc ('K') | « chrome/browser/ui/views/external_protocol_dialog.cc ('k') | chrome/browser/ui/views/javascript_app_modal_dialog_views.cc » ('j') | chrome/chrome_browser_ui.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/hung_renderer_view.cc
diff --git a/chrome/browser/ui/views/hung_renderer_view.cc b/chrome/browser/ui/views/hung_renderer_view.cc
index 3aa915f355d8f48c8892c1b811938f1e13a9fae8..05d13158b489155009c6f836560e9a87e33dc5cb 100644
--- a/chrome/browser/ui/views/hung_renderer_view.cc
+++ b/chrome/browser/ui/views/hung_renderer_view.cc
@@ -14,10 +14,10 @@
#include "chrome/browser/ui/chrome_web_modal_dialog_manager_delegate.h"
#include "chrome/browser/ui/tab_contents/core_tab_helper.h"
#include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
-#include "chrome/browser/ui/views/constrained_window_views.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/logging_chrome.h"
#include "chrome/grit/generated_resources.h"
+#include "components/constrained_window/constrained_window_views.h"
#include "components/web_modal/web_contents_modal_dialog_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
@@ -232,7 +232,7 @@ void HungRendererDialogView::ShowForWebContents(WebContents* contents) {
Browser* browser = chrome::FindBrowserWithWebContents(contents);
if (browser) {
ChromeWebModalDialogManagerDelegate* manager = browser;
msw 2014/10/22 21:32:43 nit: Is |manager| necessary?
oshima 2014/10/22 22:39:08 See my comment above.
msw 2014/10/23 18:49:05 Acknowledged.
- UpdateBrowserModalDialogPosition(
+ UpdateWidgetModalDialogPosition(
GetWidget(), manager->GetWebContentsModalDialogHost());
}
« chrome/browser/ui/views/chrome_constrained_window_views_client.cc ('K') | « chrome/browser/ui/views/external_protocol_dialog.cc ('k') | chrome/browser/ui/views/javascript_app_modal_dialog_views.cc » ('j') | chrome/chrome_browser_ui.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698