Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: components/constrained_window/constrained_window_views_unittest.cc

Issue 658383003: Componentize Constrained Window Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/constrained_window_views.h" 5 #include "components/constrained_window/constrained_window_views.h"
6 6
7 #include "components/web_modal/test_web_contents_modal_dialog_host.h" 7 #include "components/web_modal/test_web_contents_modal_dialog_host.h"
8 #include "ui/gfx/native_widget_types.h" 8 #include "ui/gfx/native_widget_types.h"
9 #include "ui/gfx/point.h" 9 #include "ui/gfx/point.h"
10 #include "ui/gfx/rect.h" 10 #include "ui/gfx/rect.h"
11 #include "ui/gfx/size.h" 11 #include "ui/gfx/size.h"
12 #include "ui/views/border.h" 12 #include "ui/views/border.h"
13 #include "ui/views/test/views_test_base.h" 13 #include "ui/views/test/views_test_base.h"
14 #include "ui/views/widget/widget.h" 14 #include "ui/views/widget/widget.h"
15 #include "ui/views/window/dialog_delegate.h" 15 #include "ui/views/window/dialog_delegate.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 DialogContents* contents_; 83 DialogContents* contents_;
84 scoped_ptr<web_modal::TestWebContentsModalDialogHost> dialog_host_; 84 scoped_ptr<web_modal::TestWebContentsModalDialogHost> dialog_host_;
85 scoped_ptr<Widget> dialog_; 85 scoped_ptr<Widget> dialog_;
86 86
87 DISALLOW_COPY_AND_ASSIGN(ConstrainedWindowViewsTest); 87 DISALLOW_COPY_AND_ASSIGN(ConstrainedWindowViewsTest);
88 }; 88 };
89 89
90 // Make sure a dialog that increases its preferred size grows on the next 90 // Make sure a dialog that increases its preferred size grows on the next
91 // position update. 91 // position update.
92 TEST_F(ConstrainedWindowViewsTest, GrowModalDialogSize) { 92 TEST_F(ConstrainedWindowViewsTest, GrowModalDialogSize) {
93 UpdateBrowserModalDialogPosition(dialog(), dialog_host()); 93 UpdateWidgetModalDialogPosition(dialog(), dialog_host());
94 gfx::Size expected_size = GetDialogSize(); 94 gfx::Size expected_size = GetDialogSize();
95 gfx::Size preferred_size = contents()->GetPreferredSize(); 95 gfx::Size preferred_size = contents()->GetPreferredSize();
96 expected_size.Enlarge(50, 50); 96 expected_size.Enlarge(50, 50);
97 preferred_size.Enlarge(50, 50); 97 preferred_size.Enlarge(50, 50);
98 contents()->set_preferred_size(preferred_size); 98 contents()->set_preferred_size(preferred_size);
99 UpdateBrowserModalDialogPosition(dialog(), dialog_host()); 99 UpdateWidgetModalDialogPosition(dialog(), dialog_host());
100 EXPECT_EQ(expected_size.ToString(), GetDialogSize().ToString()); 100 EXPECT_EQ(expected_size.ToString(), GetDialogSize().ToString());
101 } 101 }
102 102
103 // Make sure a dialog that reduces its preferred size shrinks on the next 103 // Make sure a dialog that reduces its preferred size shrinks on the next
104 // position update. 104 // position update.
105 TEST_F(ConstrainedWindowViewsTest, ShrinkModalDialogSize) { 105 TEST_F(ConstrainedWindowViewsTest, ShrinkModalDialogSize) {
106 UpdateBrowserModalDialogPosition(dialog(), dialog_host()); 106 UpdateWidgetModalDialogPosition(dialog(), dialog_host());
107 gfx::Size expected_size = GetDialogSize(); 107 gfx::Size expected_size = GetDialogSize();
108 gfx::Size preferred_size = contents()->GetPreferredSize(); 108 gfx::Size preferred_size = contents()->GetPreferredSize();
109 expected_size.Enlarge(-50, -50); 109 expected_size.Enlarge(-50, -50);
110 preferred_size.Enlarge(-50, -50); 110 preferred_size.Enlarge(-50, -50);
111 contents()->set_preferred_size(preferred_size); 111 contents()->set_preferred_size(preferred_size);
112 UpdateBrowserModalDialogPosition(dialog(), dialog_host()); 112 UpdateWidgetModalDialogPosition(dialog(), dialog_host());
113 EXPECT_EQ(expected_size.ToString(), GetDialogSize().ToString()); 113 EXPECT_EQ(expected_size.ToString(), GetDialogSize().ToString());
114 } 114 }
115 115
116 // Make sure browser modal dialogs are not affected by restrictions on web 116 // Make sure browser modal dialogs are not affected by restrictions on web
117 // content modal dialog maximum sizes. 117 // content modal dialog maximum sizes.
118 TEST_F(ConstrainedWindowViewsTest, MaximumBrowserDialogSize) { 118 TEST_F(ConstrainedWindowViewsTest, MaximumBrowserDialogSize) {
119 UpdateBrowserModalDialogPosition(dialog(), dialog_host()); 119 UpdateWidgetModalDialogPosition(dialog(), dialog_host());
120 gfx::Size dialog_size = GetDialogSize(); 120 gfx::Size dialog_size = GetDialogSize();
121 gfx::Size max_dialog_size = dialog_size; 121 gfx::Size max_dialog_size = dialog_size;
122 max_dialog_size.Enlarge(-50, -50); 122 max_dialog_size.Enlarge(-50, -50);
123 dialog_host()->set_max_dialog_size(max_dialog_size); 123 dialog_host()->set_max_dialog_size(max_dialog_size);
124 UpdateBrowserModalDialogPosition(dialog(), dialog_host()); 124 UpdateWidgetModalDialogPosition(dialog(), dialog_host());
125 EXPECT_EQ(dialog_size.ToString(), GetDialogSize().ToString()); 125 EXPECT_EQ(dialog_size.ToString(), GetDialogSize().ToString());
126 } 126 }
127 127
128 // Web content modal dialogs should not get a size larger than what the dialog 128 // Web content modal dialogs should not get a size larger than what the dialog
129 // host gives as the maximum size. 129 // host gives as the maximum size.
130 TEST_F(ConstrainedWindowViewsTest, MaximumWebContentsDialogSize) { 130 TEST_F(ConstrainedWindowViewsTest, MaximumWebContentsDialogSize) {
131 UpdateWebContentsModalDialogPosition(dialog(), dialog_host()); 131 UpdateWebContentsModalDialogPosition(dialog(), dialog_host());
132 gfx::Size full_dialog_size = GetDialogSize(); 132 gfx::Size full_dialog_size = GetDialogSize();
133 gfx::Size max_dialog_size = full_dialog_size; 133 gfx::Size max_dialog_size = full_dialog_size;
134 max_dialog_size.Enlarge(-50, -50); 134 max_dialog_size.Enlarge(-50, -50);
(...skipping 10 matching lines...) Expand all
145 145
146 // Increasing the maximum dialog size should bring the dialog back to its 146 // Increasing the maximum dialog size should bring the dialog back to its
147 // original size. 147 // original size.
148 max_dialog_size.Enlarge(100, 100); 148 max_dialog_size.Enlarge(100, 100);
149 dialog_host()->set_max_dialog_size(max_dialog_size); 149 dialog_host()->set_max_dialog_size(max_dialog_size);
150 UpdateWebContentsModalDialogPosition(dialog(), dialog_host()); 150 UpdateWebContentsModalDialogPosition(dialog(), dialog_host());
151 EXPECT_EQ(full_dialog_size.ToString(), GetDialogSize().ToString()); 151 EXPECT_EQ(full_dialog_size.ToString(), GetDialogSize().ToString());
152 } 152 }
153 153
154 } // namespace views 154 } // namespace views
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698