Componentize Constrained Window Views

chrome/chrome_browser_ui.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chrome_browser_ui_non_ios_sources': [
       'browser/ui/accelerator_utils.h',
       'browser/ui/android/android_about_app_info.cc',
       'browser/ui/android/android_about_app_info.h',
@@ skipping 1912 matching lines @@
       'browser/ui/views/bookmarks/bookmark_editor_view.cc',
       'browser/ui/views/bookmarks/bookmark_editor_view.h',
       'browser/ui/views/bookmarks/bookmark_menu_controller_observer.h',
       'browser/ui/views/bookmarks/bookmark_menu_controller_views.cc',
       'browser/ui/views/bookmarks/bookmark_menu_controller_views.h',
       'browser/ui/views/bookmarks/bookmark_menu_delegate.cc',
       'browser/ui/views/bookmarks/bookmark_menu_delegate.h',
       'browser/ui/views/bookmarks/bookmark_sync_promo_view.cc',
       'browser/ui/views/bookmarks/bookmark_sync_promo_view.h',
       'browser/ui/views/certificate_viewer_win.cc',
+      'browser/ui/views/chrome_constrained_window_views_client.cc',
+      'browser/ui/views/chrome_constrained_window_views_client.h',
       'browser/ui/views/chrome_views_delegate_chromeos.cc',
       'browser/ui/views/chrome_web_dialog_view.cc',
       'browser/ui/views/collected_cookies_views.cc',
       'browser/ui/views/collected_cookies_views.h',
       'browser/ui/views/color_chooser_aura.cc',
       'browser/ui/views/color_chooser_aura.h',
       'browser/ui/views/color_chooser_win.cc',
       'browser/ui/views/confirm_bubble_views.cc',
       'browser/ui/views/confirm_bubble_views.h',
       'browser/ui/views/conflicting_module_view_win.cc',
       'browser/ui/views/conflicting_module_view_win.h',
       'browser/ui/views/constrained_web_dialog_delegate_views.cc',
-      'browser/ui/views/constrained_window_views.cc',
-      'browser/ui/views/constrained_window_views.h',
       'browser/ui/views/content_setting_bubble_contents.cc',
       'browser/ui/views/content_setting_bubble_contents.h',
       'browser/ui/views/cookie_info_view.cc',
       'browser/ui/views/cookie_info_view.h',
       'browser/ui/views/create_application_shortcut_view.cc',
       'browser/ui/views/create_application_shortcut_view.h',
       'browser/ui/views/critical_notification_bubble_view.cc',
       'browser/ui/views/critical_notification_bubble_view.h',
       'browser/ui/views/crypto_module_password_dialog_view.cc',
       'browser/ui/views/crypto_module_password_dialog_view.h',
@@ skipping 810 matching lines @@
           'conditions': [
             ['chromeos == 0 and OS!="mac"', {
               'sources': [ '<@(chrome_browser_ui_views_non_chromeos_sources)' ],
             }],
             ['use_ash == 1', {
               'sources': [ '<@(chrome_browser_ui_ash_views_sources)' ],
             }],
             ['OS!="mac"', {
               'sources': [ '<@(chrome_browser_ui_views_non_mac_sources)' ],
               'dependencies': [
+                '<(DEPTH)/components/components.gyp:constrained_window',

[msw, 2014/10/22 21:32:43]

This perhaps should be simply contingent on 'toolkit_views==1', not sure if the
'OS!="mac"' condition is necessary, but perhaps it doesn't matter much for now.
+CC andresantoso for thoughts.

[Andre, 2014/10/22 21:45:03]

Yep, but we probably should do that when contrained_window_views compiles for
MacViews, which it does not yet right now.
So this looks right for now.

                 '<(DEPTH)/extensions/components/extensions_components.gyp:native_app_window',
               ],
             }],
           ],
         }],
         ['use_aura==1 and chromeos==0 and use_ozone==0 and OS=="linux"', {
           'dependencies': [
             # gtk2 is the only component that can interact with gtk2 in our new
             # world.
             'browser/ui/libgtk2ui/libgtk2ui.gyp:gtk2ui',
@@ skipping 244 matching lines @@
         }],
         ['OS!="android" and OS!="ios"', {
           'dependencies': [
             '../device/bluetooth/bluetooth.gyp:device_bluetooth',
           ],
         }],
       ],
     },
   ],
 }