Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 658363002: Fix null pointer exception when attempting to load an image without the target (Closed)

Created:
6 years, 2 months ago by caseq
Modified:
6 years, 2 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Fix null pointer exception when attempting to load an image without the target - properly annotated TracingModel.Event fields to let compiler catch the problem; - check target is not null before using it. BUG=424503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingModel.js View 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
6 years, 2 months ago (2014-10-17 11:58:10 UTC) #2
caseq
Note the check for null is later than it could be to keep the closure ...
6 years, 2 months ago (2014-10-17 11:59:30 UTC) #3
yurys
lgtm
6 years, 2 months ago (2014-10-17 12:30:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658363002/1
6 years, 2 months ago (2014-10-17 12:34:39 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 13:37:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183889

Powered by Google App Engine
This is Rietveld 408576698