Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 65833003: Mark cctest/test-alloc/CodeRange as flaky on Windows (Closed)

Created:
7 years, 1 month ago by yurys
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Mark cctest/test-alloc/CodeRange as flaky on Windows BUG=v8:3005 LOG=N R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17771

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
7 years, 1 month ago (2013-11-14 13:32:32 UTC) #1
Michael Achenbach
https://codereview.chromium.org/65833003/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/65833003/diff/1/test/cctest/cctest.status#newcode72 test/cctest/cctest.status:72: 'cctest/test-alloc/CodeRange': [PASS, FAIL], Please mark as [PASS, FLAKY]
7 years, 1 month ago (2013-11-14 14:41:36 UTC) #2
yurys
https://codereview.chromium.org/65833003/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/65833003/diff/1/test/cctest/cctest.status#newcode72 test/cctest/cctest.status:72: 'cctest/test-alloc/CodeRange': [PASS, FAIL], On 2013/11/14 14:41:37, machenbach wrote: > ...
7 years, 1 month ago (2013-11-15 08:47:32 UTC) #3
Michael Achenbach
LGTM PASS||FAIL is a bit less strict, since it will hide failures. We do this ...
7 years, 1 month ago (2013-11-15 09:03:56 UTC) #4
yurys
On 2013/11/15 09:03:56, machenbach wrote: > LGTM > > PASS||FAIL is a bit less strict, ...
7 years, 1 month ago (2013-11-15 09:07:59 UTC) #5
Michael Achenbach
If nobody looks at that test within the next two weeks, we make it PASS||FAIL ...
7 years, 1 month ago (2013-11-15 09:08:38 UTC) #6
yurys
7 years, 1 month ago (2013-11-15 09:10:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r17771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698