[fsp] Store observed entries in preferences.

[fsp] Store observed entries in preferences.

This patch remembers the observed entries in preferences, so they are restored
after a reboot.

Note, that more tests will come after a refactoring out writing to preferences
from Service, which is coming soon/

TEST=unit_tests, browser_tests: *FileSystemProvider*RememberFileSystem*, *FileSystemProvider*RestoreFileSystem*
BUG=248427
Committed: https://crrev.com/739f3d107f09386a8e21b5cf51563df2759f8ab7
Cr-Commit-Position: refs/heads/master@{#300231}

[mtomasz, 2014-10-17 07:33:28]

mtomasz@chromium.org changed reviewers:
+ hirono@chromium.org

[mtomasz, 2014-10-17 07:33:28]

@hirono: PTAL. Thanks!

[hirono, 2014-10-17 08:22:23]

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/service.cc (right):

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service.cc:529:
DCHECK(file_system_value);
nit: This check is redundant.

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/service_unittest.cc (right):

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service_unittest.cc:128:
base::DictionaryValue* observed_entries = new base::DictionaryValue();
nit: base::DictionaryValue* const

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service_unittest.cc:131:
base::DictionaryValue* observed_entry_value = new base::DictionaryValue();
nit: base::DictionaryValue* const

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service_unittest.cc:395:
ProvidedFileSystemInterface* file_system =
nit: const

[mtomasz, 2014-10-20 05:11:57]

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/service.cc (right):

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service.cc:529:
DCHECK(file_system_value);
On 2014/10/17 08:22:23, hirono wrote:
> nit: This check is redundant.

Why? GetWithoutPathExpansion may fail if the key is not found, and we would get
a NULL pointer here.

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/service_unittest.cc (right):

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service_unittest.cc:128:
base::DictionaryValue* observed_entries = new base::DictionaryValue();
On 2014/10/17 08:22:23, hirono wrote:
> nit: base::DictionaryValue* const

Done.

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service_unittest.cc:131:
base::DictionaryValue* observed_entry_value = new base::DictionaryValue();
On 2014/10/17 08:22:23, hirono wrote:
> nit: base::DictionaryValue* const

Done.

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service_unittest.cc:395:
ProvidedFileSystemInterface* file_system =
On 2014/10/17 08:22:23, hirono wrote:
> nit: const

Done.

[hirono, 2014-10-20 05:18:50]

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/service.cc (right):

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service.cc:529:
DCHECK(file_system_value);
On 2014/10/20 05:11:56, mtomasz wrote:
> On 2014/10/17 08:22:23, hirono wrote:
> > nit: This check is redundant.
> 
> Why? GetWithoutPathExpansion may fail if the key is not found, and we would
get
> a NULL pointer here.

It looks the value has been already checked at #477.
DCHECK(observed_entry_value)?

[mtomasz, 2014-10-20 05:23:27]

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/service.cc (right):

https://codereview.chromium.org/658313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/service.cc:529:
DCHECK(file_system_value);
On 2014/10/20 05:18:49, hirono wrote:
> On 2014/10/20 05:11:56, mtomasz wrote:
> > On 2014/10/17 08:22:23, hirono wrote:
> > > nit: This check is redundant.
> > 
> > Why? GetWithoutPathExpansion may fail if the key is not found, and we would
> get
> > a NULL pointer here.
> 
> It looks the value has been already checked at #477.
> DCHECK(observed_entry_value)?

You're right! Fixed.

[hirono, 2014-10-20 05:28:23]

lgtm!

[mtomasz, 2014-10-20 05:33:13]

On 2014/10/20 05:28:23, hirono wrote:
> lgtm!

Thanks!

[mtomasz, 2014-10-20 05:33:18]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-10-20 05:33:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/658313002/40001

[commit-bot: I haz the power, 2014-10-20 09:32:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-20 09:33:04]

Patchset 3 (id:??) landed as
https://crrev.com/739f3d107f09386a8e21b5cf51563df2759f8ab7
Cr-Commit-Position: refs/heads/master@{#300231}