Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 658293003: DevTools: initialize "format script" button with current UISourceCode (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

DevTools: initialize "format script" button with current UISourceCode As of today, the "format script" button is initialized as hidden and will update its state in response to editorSelected event. However, in case the event is sent prior to button construction, it should be initialized with current selected editor. BUG=424089 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
lushnikov
PTAL
6 years, 2 months ago (2014-10-17 10:00:34 UTC) #1
vsevik
lgtm
6 years, 2 months ago (2014-10-17 10:50:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658293003/1
6 years, 2 months ago (2014-10-17 10:50:32 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 11:59:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183881

Powered by Google App Engine
This is Rietveld 408576698