Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 658283003: [arm] Prefer BIC over BFC. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[arm] Prefer BIC over BFC. BFC requires same register for input and output and causes introduction of some unneccesary gap moves. TEST=unittests,mjsunit R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -37 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 5 chunks +22 lines, -11 lines 0 comments Download
A test/mjsunit/asm/word32and.js View 1 chunk +29 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 4 chunks +35 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-17 06:34:25 UTC) #2
Sven Panne
lgtm
6 years, 2 months ago (2014-10-17 07:06:03 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-17 07:08:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24678 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698