content/browser/browser_child_process_host_impl.cc - Issue 658253002: Stop early exit watcher in BrowserChildProcessHostImpl::OnChildDisconnected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_child_process_host_impl.cc

Issue 658253002: Stop early exit watcher in BrowserChildProcessHostImpl::OnChildDisconnected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/browser_child_process_host_impl.cc

diff --git a/content/browser/browser_child_process_host_impl.cc b/content/browser/browser_child_process_host_impl.cc

index f2f28278c2199ee5eba6fc4eb65b6b2426d7a5ff..82792bda158b953e098b0a6645c8449bfd8f3b9c 100644

--- a/content/browser/browser_child_process_host_impl.cc

+++ b/content/browser/browser_child_process_host_impl.cc

@@ -265,6 +265,9 @@ bool BrowserChildProcessHostImpl::CanShutdown() {

void BrowserChildProcessHostImpl::OnChildDisconnected() {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+#if defined(OS_WIN)

sky 2014/10/20 16:27:34 Document why this is needed.

+ early_exit_watcher_.StopWatching();

+#endif

if (child_process_.get() || data_.handle) {

DCHECK(data_.handle != base::kNullProcessHandle);

int exit_code;

« no previous file with comments | « no previous file | no next file » | no next file with comments »