Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 658223003: Merge to M39: [GCM] Updating GCM Status Syncer to the new Experiment Status pb (Closed)

Created:
6 years, 2 months ago by jianli
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, haitaol+watch_chromium.org, pvalenzuela+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

Merge to M39: [GCM] Updating GCM Status Syncer to the new Experiment Status pb BUG=421210 TBR=jianli@chromium.org Review URL: https://codereview.chromium.org/635093002 Cr-Commit-Position: refs/heads/master@{#298771} (cherry picked from commit 3689f8d171c79fb6695eae6c65b6fd517f5a09c0) Committed: https://chromium.googlesource.com/chromium/src/+/9155537a981bc8a7f5462a34a30cf1e8713a70ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -67 lines) Patch
M components/gcm_driver.gypi View 2 chunks +1 line, -1 line 0 comments Download
M components/gcm_driver/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_request.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_request_unittest.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
D components/gcm_driver/proto/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D components/gcm_driver/proto/gcm_channel_status.proto View 1 chunk +0 lines, -34 lines 0 comments Download
M sync/protocol/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + sync/protocol/experiment_status.proto View 2 chunks +9 lines, -7 lines 0 comments Download
M sync/sync.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jianli
6 years, 2 months ago (2014-10-16 20:07:50 UTC) #2
jianli
6 years, 2 months ago (2014-10-16 20:09:39 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9155537a981bc8a7f5462a34a30cf1e8713a70ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698