Issue 658223002: replace newly added OVERRIDE with override in service worker unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 658223002: replace newly added OVERRIDE with override in service worker unit tests (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore

Modified:
6 years, 2 months ago

Reviewers:
falken

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

replace newly added OVERRIDE with override in service worker unit tests BUG=417463 Committed: https://crrev.com/d7c94dea65a04119b07f4f9a1d9b9ec6c48680e4 Cr-Commit-Position: refs/heads/master@{#300011}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mostyn Bramley-Moore

@falken: can you please give this tiny fixup a green light? Followup to https://codereview.chromium.org/637243003

6 years, 2 months ago (2014-10-16 18:57:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658223002/1

6 years, 2 months ago (2014-10-16 21:42:41 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-16 23:41:20 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d7c94dea65a04119b07f4f9a1d9b9ec6c48680e4
Cr-Commit-Position: refs/heads/master@{#300011}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages