Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 658183003: [Athena] Hotfix for IME component extension loading crash on sign in (Closed)

Created:
6 years, 1 month ago by Nikita (slow)
Modified:
6 years, 1 month ago
Reviewers:
Shu Chen
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Athena] Hotfix for IME component extension loading crash on sign in ExtensionService is not initialized. BUG=426787 Committed: https://crrev.com/fece7e7775fc87dd72c649919722fdb2ec93f8fe Cr-Commit-Position: refs/heads/master@{#301343}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove debug code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nikita (slow)
6 years, 1 month ago (2014-10-27 10:37:14 UTC) #2
Shu Chen
lgtm
6 years, 1 month ago (2014-10-27 10:37:47 UTC) #3
Nikita (slow)
https://codereview.chromium.org/658183003/diff/1/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc File chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc (right): https://codereview.chromium.org/658183003/diff/1/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc#newcode303 chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:303: // if (base::SysInfo::IsRunningOnChromeOS()) { Removing these in next patchset.
6 years, 1 month ago (2014-10-27 10:38:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658183003/20001
6 years, 1 month ago (2014-10-27 10:40:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 11:26:56 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 11:27:41 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fece7e7775fc87dd72c649919722fdb2ec93f8fe
Cr-Commit-Position: refs/heads/master@{#301343}

Powered by Google App Engine
This is Rietveld 408576698