content/shell/renderer/test_runner/event_sender.cc - Issue 658183002: Add support for DOM3 KeyboardEvent keycode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/event_sender.cc

Issue 658183002: Add support for DOM3 KeyboardEvent keycode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Embedder API to allow access to DOM3 code value based on native key value Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/test_runner/event_sender.cc

diff --git a/content/shell/renderer/test_runner/event_sender.cc b/content/shell/renderer/test_runner/event_sender.cc

index dc8e47383a1e86f0f8d74981de708f909335f226..f78f134b753457cce86bfc58b309b2bc5f5e50ba 100644

--- a/content/shell/renderer/test_runner/event_sender.cc

+++ b/content/shell/renderer/test_runner/event_sender.cc

@@ -1270,6 +1270,10 @@ void EventSender::KeyDown(const std::string& code_str,

code = ui::VKEY_BACK;

} else if ("escape" == code_str) {

code = ui::VKEY_ESCAPE;

+ } else if ("scrollLock" == code_str) {

apavlov 2014/11/12 08:56:32 is this a drive-by change?

Habib Virji 2014/11/24 15:13:09 Actually these changes are not needed any more, it

+ code = ui::VKEY_SCROLL;

+ } else if ("pause" == code_str) {

+ code = ui::VKEY_PAUSE;

} else {

// Compare the input string with the function-key names defined by the

// DOM spec (i.e. "F1",...,"F24"). If the input string is a function-key