Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: content/renderer/render_view_impl.h

Issue 658183002: Add support for DOM3 KeyboardEvent keycode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "Updated to return WebString and int instead of long" Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index d472f0dec0c9d70ae2cfd954ab5082a9ba4a6487..c6fb77ad2bf8031493d5dabe27589c8dac4c9856 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -361,6 +361,8 @@ class CONTENT_EXPORT RenderViewImpl
virtual void saveImageFromDataURL(const blink::WebString& data_url);
virtual void didCancelCompositionOnSelectionChange();
virtual bool handleCurrentKeyboardEvent();
+ virtual blink::WebString domCodeStringFromEnum(int dom_code);
+ virtual int domEnumFromCodeString(const blink::WebString& codeString);
piman 2015/01/28 01:18:04 Why do these need to be virtual members of WebView
Habib Virji 2015/01/28 10:02:11 No they do. Both functions are trying to access
Wez 2015/01/29 00:51:02 These are embedder-provided APIs on the WebViewCli
virtual bool runFileChooser(
const blink::WebFileChooserParams& params,
blink::WebFileChooserCompletion* chooser_completion);

Powered by Google App Engine
This is Rietveld 408576698