Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 658173002: Reposition cast button on narrow videos (Closed)

Created:
6 years, 2 months ago by aberent
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium, whywhat
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Reposition cast button on narrow videos If a video is too narrow to display the full controls, including the cast button, on the control bar, then use an overlay cast button instead. BUG=423753 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183883

Patch Set 1 #

Patch Set 2 : Add layout test #

Patch Set 3 : trivial editorial change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -17 lines) Patch
A + LayoutTests/media/controls-cast-button-narrow.html View 1 2 3 chunks +26 lines, -17 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
aberent
6 years, 2 months ago (2014-10-16 15:25:09 UTC) #2
Mike West
Can you add a test for this functionality? Check the element's state via JS, or ...
6 years, 2 months ago (2014-10-16 17:50:55 UTC) #3
aberent
On 2014/10/16 17:50:55, Mike West wrote: > Can you add a test for this functionality? ...
6 years, 2 months ago (2014-10-17 10:18:08 UTC) #5
Mike West
Perfect, thank you. LGTM.
6 years, 2 months ago (2014-10-17 10:27:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658173002/60001
6 years, 2 months ago (2014-10-17 10:45:32 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 12:37:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as 183883

Powered by Google App Engine
This is Rietveld 408576698