Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: content/browser/loader/resource_scheduler_unittest.cc

Issue 658163002: Fixed resource scheduler to not treat non-blocking js as render-blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unit test added Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_scheduler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_scheduler_unittest.cc
diff --git a/content/browser/loader/resource_scheduler_unittest.cc b/content/browser/loader/resource_scheduler_unittest.cc
index 3697b6aaf3c15f87eb8f4d723eabe5ac788e21d4..a22c95a82403fc3ef129316045025101a6678322 100644
--- a/content/browser/loader/resource_scheduler_unittest.cc
+++ b/content/browser/loader/resource_scheduler_unittest.cc
@@ -327,6 +327,17 @@ TEST_F(ResourceSchedulerTest, OneLowLoadsUntilCriticalComplete) {
EXPECT_TRUE(low2->started());
}
+TEST_F(ResourceSchedulerTest, LowDoesNotBlockCriticalComplete) {
+ scoped_ptr<TestRequest> low(NewRequest("http://host/low", net::LOW));
+ scoped_ptr<TestRequest> lowest(NewRequest("http://host/lowest", net::LOWEST));
+ scoped_ptr<TestRequest> lowest2(NewRequest("http://host/lowest", net::LOWEST));
mmenke 2014/10/16 17:19:42 nit: Fix line length.
Pat Meenan 2014/10/16 18:20:55 Done.
+ EXPECT_TRUE(low->started());
+ EXPECT_TRUE(lowest->started());
+ EXPECT_FALSE(lowest2->started());
+ scheduler_.OnWillInsertBody(kChildId, kRouteId);
+ EXPECT_TRUE(lowest2->started());
+}
+
TEST_F(ResourceSchedulerTest, OneLowLoadsUntilBodyInsertedExceptSpdy) {
http_server_properties_.SetSupportsSpdy(
net::HostPortPair("spdyhost", 443), true);
« no previous file with comments | « content/browser/loader/resource_scheduler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698