Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 658153003: cc: clang-format shader.cc (Closed)

Created:
6 years, 2 months ago by enne (OOO)
Modified:
6 years, 2 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews, rosca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: clang-format shader.cc Previously this file could not be formatted because of all the shader code in magic macros to make it less irritating to edit. It turns out "clang-format off" and "clang-format on" in comments make it possible to selectively apply formatting, so do this for all the shaders. R=danakj@chromium.org BUG=none Committed: https://crrev.com/535c75f4da3d754d0716305405a70418b99502de Cr-Commit-Position: refs/heads/master@{#299996}

Patch Set 1 #

Patch Set 2 : format the file #

Total comments: 11

Patch Set 3 : Add clang-format inside / just clang-format change #

Patch Set 4 : And formatted #

Patch Set 5 : Fix mismatching #

Patch Set 6 : Final formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+795 lines, -669 lines) Patch
M cc/output/shader.cc View 1 2 3 4 5 36 chunks +795 lines, -669 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
enne (OOO)
PTAL Patch 1 has the real changes. Patch 2 is just me running format on ...
6 years, 2 months ago (2014-10-16 18:44:05 UTC) #1
danakj
https://codereview.chromium.org/658153003/diff/20001/cc/output/shader.cc File cc/output/shader.cc (right): https://codereview.chromium.org/658153003/diff/20001/cc/output/shader.cc#newcode364 cc/output/shader.cc:364: // clang-format on why is this at column 0 ...
6 years, 2 months ago (2014-10-16 19:25:11 UTC) #2
enne (OOO)
https://codereview.chromium.org/658153003/diff/20001/cc/output/shader.cc File cc/output/shader.cc (right): https://codereview.chromium.org/658153003/diff/20001/cc/output/shader.cc#newcode433 cc/output/shader.cc:433: ); // NOLINT(whitespace/parens) On 2014/10/16 19:25:10, danakj wrote: > ...
6 years, 2 months ago (2014-10-16 19:39:30 UTC) #3
danakj
LGTM
6 years, 2 months ago (2014-10-16 20:59:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658153003/100001
6 years, 2 months ago (2014-10-16 21:05:13 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 2 months ago (2014-10-16 22:46:49 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 22:47:44 UTC) #8
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/535c75f4da3d754d0716305405a70418b99502de
Cr-Commit-Position: refs/heads/master@{#299996}

Powered by Google App Engine
This is Rietveld 408576698