Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 658123002: DevTools: [SASS] poll CSS for 30 seconds instead of 5 seconds. (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [SASS] poll CSS for 30 seconds instead of 5 seconds. Currently, SASSSourceMapping polls CSS for 5 seconds after the SASS change, and this turns out to be insufficient in case of complex css-processing build steps. Instead of adding one more setting "css polling duration", this patch tries to solve most of the problems by increasing polling duration to 30 seconds. BUG=421925 R=vsevik, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M Source/devtools/front_end/bindings/SASSSourceMapping.js View 3 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
lushnikov
Please, take a look
6 years, 2 months ago (2014-10-16 13:05:43 UTC) #1
vsevik
lgtm
6 years, 2 months ago (2014-10-16 13:21:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658123002/1
6 years, 2 months ago (2014-10-16 13:22:15 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 14:31:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183819

Powered by Google App Engine
This is Rietveld 408576698