Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: sky/tools/debugger/debugger.cc

Issue 658113004: Teach tools/skydb how to take a URL as a parameter. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: std library, ouch. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/tools/debugger/prompt/prompt.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/debugger/debugger.cc
diff --git a/sky/tools/debugger/debugger.cc b/sky/tools/debugger/debugger.cc
index 8b0e0d14cf723b74ed1203114184d0b3d6b4c19a..e4aa111a0abea8f19f4282d6666e3f83be1c564d 100644
--- a/sky/tools/debugger/debugger.cc
+++ b/sky/tools/debugger/debugger.cc
@@ -74,11 +74,13 @@ class SkyDebugger : public mojo::ApplicationDelegate,
virtual void OnViewManagerDisconnected(
mojo::ViewManager* view_manager) override {
+ CHECK(false); // FIXME: This is dead code, why?
view_manager_ = nullptr;
root_ = nullptr;
}
virtual void OnViewDestroyed(mojo::View* view) override {
+ CHECK(false); // FIXME: This is dead code, why?
view->RemoveObserver(this);
}
« no previous file with comments | « no previous file | sky/tools/debugger/prompt/prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698