Issue 658113004: Teach tools/skydb how to take a URL as a parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 658113004: Teach tools/skydb how to take a URL as a parameter. (Closed)

Created:
6 years, 2 months ago by eseidel

Modified:
6 years, 2 months ago

Reviewers:
abarth-chromium

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Visibility:
Public.

More Reviews

Description

Teach tools/skydb how to take a URL as a parameter. Turns out our shut-down code in debugger.cc is never called. Need to talk to Ben to figure out how to listen for the CloseWindow. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5f629609e8e14a0642c4f95df8c34e6fd5b5d09a

Patch Set 2 : Remove debugging code #

Patch Set 4 : std library, ouch. #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -11 lines)			Patch
M	sky/tools/debugger/debugger.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/tools/debugger/prompt/prompt.cc	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download
M	sky/tools/skydb	View		1 chunk	+21 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

https://codereview.chromium.org/658113004/diff/1/sky/tools/debugger/prompt/prompt.cc File sky/tools/debugger/prompt/prompt.cc (right): https://codereview.chromium.org/658113004/diff/1/sky/tools/debugger/prompt/prompt.cc#newcode47 sky/tools/debugger/prompt/prompt.cc:47: url_ = app->args()[1]; Should we check the number of ...

6 years, 2 months ago (2014-10-23 20:34:41 UTC) #2

eseidel

6 years, 2 months ago (2014-10-23 20:40:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
5f629609e8e14a0642c4f95df8c34e6fd5b5d09a (presubmit successful).