Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 658113003: [Mojo] ApplicationRunnerChromium should dump stacks in debug (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
jamesr, eseidel
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mojo] ApplicationRunnerChromium should dump stacks in debug This behavior matches what we do in renderer_main.cc. R=jamesr@chromium.org Committed: https://crrev.com/72a65e46a0ae1000662856838179f3ee46a2b6c1 Cr-Commit-Position: refs/heads/master@{#299961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M mojo/application/application_runner_chromium.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
abarth-chromium
6 years, 2 months ago (2014-10-16 16:41:23 UTC) #1
eseidel
Blink/Chrome is going to want to do similar as well, along with ripping out WTF's ...
6 years, 2 months ago (2014-10-16 17:00:32 UTC) #3
jamesr
lgtm
6 years, 2 months ago (2014-10-16 17:30:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658113003/1
6 years, 2 months ago (2014-10-16 19:41:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 19:48:05 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72a65e46a0ae1000662856838179f3ee46a2b6c1 Cr-Commit-Position: refs/heads/master@{#299961}
6 years, 2 months ago (2014-10-16 19:53:11 UTC) #8
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-17 06:52:34 UTC) #9
Message was sent while issue was closed.
On 2014/10/16 at 17:00:32, eseidel wrote:
> Blink/Chrome is going to want to do similar as well, along with ripping out
WTF's signal handlers and backtrace printing.

the content module invokes this method already. The WTF signal handlers are
unused, we could just remove them.

Removing the backtrace printing would require adding a dependency on base/
(which might make sense anyways)

Powered by Google App Engine
This is Rietveld 408576698