Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 658103003: Support map and list literals in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer2dart/test/end2end_test.dart » ('j') | pkg/analyzer2dart/test/end2end_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index 7acf50452f33de7eb9d6f68d41c8a190c30c1677..060d8037fc8c46d223e6b469694c895f0f91f405 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -6,6 +6,7 @@ library analyzer2dart.cps_generator;
import 'package:analyzer/analyzer.dart';
+import 'package:compiler/implementation/dart_types.dart' as dart2js;
import 'package:compiler/implementation/elements/elements.dart' as dart2js;
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/generated/element.dart' as analyzer;
@@ -230,4 +231,23 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
subbuild(node.thenStatement),
subbuild(node.elseStatement));
}
+
+ @override
+ ir.Node visitListLiteral(ListLiteral node) {
+ dart2js.InterfaceType type = converter.convertType(node.staticType);
+ // TODO(johnniwinther): Use `build` instead of `(e) => build(e)` when issue
+ // 18630 has been resolved.
+ Iterable<ir.Primitive> values = node.elements.map((e) => build(e));
+ return irBuilder.buildListLiteral(type, values);
+ }
+
+ @override
+ ir.Node visitMapLiteral(MapLiteral node) {
+ dart2js.InterfaceType type = converter.convertType(node.staticType);
+ Iterable<ir.Primitive> keys =
+ node.entries.map((MapLiteralEntry entry) => build(entry.key));
+ Iterable<ir.Primitive> values =
+ node.entries.map((MapLiteralEntry entry) => build(entry.value));
+ return irBuilder.buildMapLiteral(type, keys, values);
+ }
}
« no previous file with comments | « no previous file | pkg/analyzer2dart/test/end2end_test.dart » ('j') | pkg/analyzer2dart/test/end2end_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698