Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 658073002: CSP: Fix protocolless 'frame-ancestor' source expressions. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
Reviewers:
sof
CC:
blink-reviews, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

CSP: Fix protocolless 'frame-ancestor' source expressions. When checking 'frame-ancestor', we end up asking for the SecurityOrigin of the protected resource before we actually have a protected resource whose origin we could ask for. This, unsurprisingly, crashes. This patch adds a protocol property to the ContentSecurityPolicy object so that we can perform all the checks for source expressions that don't specify protocols without crashing the renderer. BUG=424074 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
A + LayoutTests/http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-protocolless-allow.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-protocolless-allow-expected.txt View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
Mind taking a look at this Jochen? I'll CC you on the crash bug for ...
6 years, 2 months ago (2014-10-16 09:06:51 UTC) #1
Mike West
Er. I forgot that Jochen's out today. Sigbjorn, mind taking a look? -mike
6 years, 2 months ago (2014-10-16 09:44:28 UTC) #3
sof
lgtm. A bit unfortunate to have to duplicate parts of the origin here, but I ...
6 years, 2 months ago (2014-10-16 10:01:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658073002/1
6 years, 2 months ago (2014-10-16 10:33:20 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 10:37:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183801

Powered by Google App Engine
This is Rietveld 408576698