Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 658063002: Fix the issue where checking a form for :valid/:invalid would trigger invalid events for its elemen… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFormElement.h
diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h
index a9804d0c3906da29af5117b8f123c15cfcd2ac80..e8a27e86cbafb7587b11994a8a2d84b0bf5dda35 100644
--- a/Source/core/html/HTMLFormElement.h
+++ b/Source/core/html/HTMLFormElement.h
@@ -47,8 +47,6 @@ public:
virtual ~HTMLFormElement();
virtual void trace(Visitor*) override;
- virtual bool matchesValidityPseudoClasses() const override final;
- virtual bool isValidElement() override final;
void setNeedsValidityCheck();
PassRefPtrWillBeRawPtr<HTMLFormControlsCollection> elements();
@@ -97,6 +95,8 @@ public:
HTMLFormControlElement* defaultButton() const;
bool checkValidity();
+ virtual bool matchesValidityPseudoClasses() const override final;
+ virtual bool isValidElement() override final;
enum AutocompleteResult {
AutocompleteResultSuccess,
@@ -151,7 +151,7 @@ private:
// Validates each of the controls, and stores controls of which 'invalid'
// event was not canceled to the specified vector. Returns true if there
// are any invalid controls in this form.
- bool checkInvalidControlsAndCollectUnhandled(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >*);
+ bool checkInvalidControlsAndCollectUnhandled(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >*, bool);
keishi 2014/10/17 04:52:37 http://www.chromium.org/blink/coding-style says "P
Bartek Nowierski 2014/10/17 05:34:57 Done.
Element* elementFromPastNamesMap(const AtomicString&);
void addToPastNamesMap(Element*, const AtomicString& pastName);

Powered by Google App Engine
This is Rietveld 408576698