Source/core/html/HTMLFormControlElement.cpp - Issue 658063002: Fix the issue where checking a form for :valid/:invalid would trigger invalid events for its elemen…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 658063002: Fix the issue where checking a form for :valid/:invalid would trigger invalid events for its elemen… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/form-pseudo-valid-style.html ('K') | « Source/core/html/HTMLFormControlElement.h ('k') | Source/core/html/HTMLFormElement.h » ('j') | Source/core/html/HTMLFormElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormControlElement.cpp

diff --git a/Source/core/html/HTMLFormControlElement.cpp b/Source/core/html/HTMLFormControlElement.cpp

index 3526e51947edbc61ba26f5b8826b2fe9d2bd844c..28556642d17e564d061ab45d10520ef15939d8a0 100644

--- a/Source/core/html/HTMLFormControlElement.cpp

+++ b/Source/core/html/HTMLFormControlElement.cpp

@@ -486,10 +486,12 @@ ValidationMessageClient* HTMLFormControlElement::validationMessageClient() const

return &page->validationMessageClient();

}

-bool HTMLFormControlElement::checkValidity(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >* unhandledInvalidControls)

+bool HTMLFormControlElement::checkValidity(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >* unhandledInvalidControls, bool fireInvalidEvent)

{

if (!willValidate() || isValidElement())

return true;

+ if (!fireInvalidEvent)

+ return false;

// An event handler can deref this object.

RefPtrWillBeRawPtr<HTMLFormControlElement> protector(this);

RefPtrWillBeRawPtr<Document> originalDocument(document());