Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 658033005: Add v8 git hashes to releases script. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach
Modified:
6 years, 2 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add v8 git hashes to releases script. Also change the tests to use git mode. BUG=chromium:410721 LOG=n TEST=script_test.py TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24664

Patch Set 1 #

Patch Set 2 : Fix revision lookup. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -55 lines) Patch
M tools/push-to-trunk/releases.py View 1 2 3 chunks +13 lines, -3 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 3 chunks +103 lines, -52 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
PTAL
6 years, 2 months ago (2014-10-16 13:20:12 UTC) #2
Michael Achenbach
Committed patchset #3 (id:40001) manually as 24664 (presubmit successful).
6 years, 2 months ago (2014-10-16 13:21:31 UTC) #3
tandrii(chromium)
lgtm
6 years, 2 months ago (2014-10-16 13:37:11 UTC) #4
tandrii(chromium)
6 years, 2 months ago (2014-10-16 13:37:12 UTC) #5
Message was sent while issue was closed.
lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698