content/renderer/media/webmediaplayer_impl.cc - Issue 65803002: Replace MessageLoopProxy with SingleThreadTaskRunner for media/filters/ + associated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_impl.cc

Issue 65803002: Replace MessageLoopProxy with SingleThreadTaskRunner for media/filters/ + associated code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webmediaplayer_impl.cc

diff --git a/content/renderer/media/webmediaplayer_impl.cc b/content/renderer/media/webmediaplayer_impl.cc

index 46e9a9198b506b504beb0eafa1fb6abc63fd7ec4..d254da46275b29078b668e431d80998353440400 100644

--- a/content/renderer/media/webmediaplayer_impl.cc

+++ b/content/renderer/media/webmediaplayer_impl.cc

@@ -172,9 +172,9 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(

pipeline_.reset(new media::Pipeline(media_loop_, media_log_.get()));

// |gpu_factories_| requires that its entry points be called on its

- // |GetMessageLoop()|. Since |pipeline_| will own decoders created from the

+ // |GetTaskRunner()|. Since |pipeline_| will own decoders created from the

// factories, require that their message loops are identical.

- DCHECK(!gpu_factories_ || (gpu_factories_->GetMessageLoop() == media_loop_));

+ DCHECK(!gpu_factories_ || (gpu_factories_->GetTaskRunner() == media_loop_));

// Let V8 know we started new thread if we did not do it yet.

// Made separate task to avoid deletion of player currently being created.

« no previous file with comments | « content/renderer/media/rtc_video_encoder.cc ('k') | media/base/bind_to_loop.h » ('j') | no next file with comments »