Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: media/filters/audio_renderer_impl.cc

Issue 65803002: Replace MessageLoopProxy with SingleThreadTaskRunner for media/filters/ + associated code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/audio_renderer_impl.cc
diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc
index a4b0370ab1237011156bf1711e07b8c5b844e5c6..879a10dc419691545891424f9afbdab694f68166 100644
--- a/media/filters/audio_renderer_impl.cc
+++ b/media/filters/audio_renderer_impl.cc
@@ -12,8 +12,8 @@
#include "base/callback.h"
#include "base/callback_helpers.h"
#include "base/logging.h"
-#include "base/message_loop/message_loop_proxy.h"
#include "base/metrics/histogram.h"
+#include "base/single_thread_task_runner.h"
#include "media/base/audio_buffer.h"
#include "media/base/audio_splicer.h"
#include "media/base/bind_to_loop.h"
@@ -38,16 +38,16 @@ void HistogramRendererEvent(AudioRendererEvent event) {
} // namespace
AudioRendererImpl::AudioRendererImpl(
- const scoped_refptr<base::MessageLoopProxy>& message_loop,
+ const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
media::AudioRendererSink* sink,
ScopedVector<AudioDecoder> decoders,
const SetDecryptorReadyCB& set_decryptor_ready_cb,
bool increase_preroll_on_underflow)
- : message_loop_(message_loop),
+ : task_runner_(task_runner),
weak_factory_(this),
sink_(sink),
decoder_selector_(new AudioDecoderSelector(
- message_loop, decoders.Pass(), set_decryptor_ready_cb)),
+ task_runner, decoders.Pass(), set_decryptor_ready_cb)),
now_cb_(base::Bind(&base::TimeTicks::Now)),
state_(kUninitialized),
sink_playing_(false),
@@ -68,7 +68,7 @@ AudioRendererImpl::~AudioRendererImpl() {
}
void AudioRendererImpl::Play(const base::Closure& callback) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
DCHECK_EQ(state_, kPaused);
@@ -83,7 +83,7 @@ void AudioRendererImpl::Play(const base::Closure& callback) {
}
void AudioRendererImpl::DoPlay_Locked() {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
lock_.AssertAcquired();
earliest_end_time_ = now_cb_.Run();
@@ -98,7 +98,7 @@ void AudioRendererImpl::DoPlay_Locked() {
}
void AudioRendererImpl::Pause(const base::Closure& callback) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
DCHECK(state_ == kPlaying || state_ == kUnderflow ||
@@ -114,7 +114,7 @@ void AudioRendererImpl::Pause(const base::Closure& callback) {
}
void AudioRendererImpl::DoPause_Locked() {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
lock_.AssertAcquired();
if (sink_playing_) {
@@ -127,7 +127,7 @@ void AudioRendererImpl::DoPause_Locked() {
}
void AudioRendererImpl::Flush(const base::Closure& callback) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
if (decrypting_demuxer_stream_) {
decrypting_demuxer_stream_->Reset(base::Bind(
@@ -139,12 +139,12 @@ void AudioRendererImpl::Flush(const base::Closure& callback) {
}
void AudioRendererImpl::ResetDecoder(const base::Closure& callback) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
decoder_->Reset(callback);
}
void AudioRendererImpl::Stop(const base::Closure& callback) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
DCHECK(!callback.is_null());
// TODO(scherkus): Consider invalidating |weak_factory_| and replacing
@@ -169,7 +169,7 @@ void AudioRendererImpl::Stop(const base::Closure& callback) {
void AudioRendererImpl::Preroll(base::TimeDelta time,
const PipelineStatusCB& cb) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
DCHECK(!sink_playing_);
@@ -204,7 +204,7 @@ void AudioRendererImpl::Initialize(DemuxerStream* stream,
const base::Closure& ended_cb,
const base::Closure& disabled_cb,
const PipelineStatusCB& error_cb) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
DCHECK(stream);
DCHECK_EQ(stream->type(), DemuxerStream::AUDIO);
DCHECK(!init_cb.is_null());
@@ -235,7 +235,7 @@ void AudioRendererImpl::Initialize(DemuxerStream* stream,
void AudioRendererImpl::OnDecoderSelected(
scoped_ptr<AudioDecoder> decoder,
scoped_ptr<DecryptingDemuxerStream> decrypting_demuxer_stream) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
scoped_ptr<AudioDecoderSelector> deleter(decoder_selector_.Pass());
@@ -292,7 +292,7 @@ void AudioRendererImpl::OnDecoderSelected(
}
void AudioRendererImpl::ResumeAfterUnderflow() {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
if (state_ == kUnderflow) {
// The "&& preroll_aborted_" is a hack. If preroll is aborted, then we
@@ -309,7 +309,7 @@ void AudioRendererImpl::ResumeAfterUnderflow() {
}
void AudioRendererImpl::SetVolume(float volume) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
DCHECK(sink_);
sink_->SetVolume(volume);
}
@@ -318,7 +318,7 @@ void AudioRendererImpl::DecodedAudioReady(
AudioDecoder::Status status,
const scoped_refptr<AudioBuffer>& buffer) {
DVLOG(1) << __FUNCTION__ << "(" << status << ")";
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
DCHECK(state_ == kPaused || state_ == kPrerolling || state_ == kPlaying ||
@@ -416,7 +416,7 @@ void AudioRendererImpl::AttemptRead() {
}
void AudioRendererImpl::AttemptRead_Locked() {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
lock_.AssertAcquired();
if (!CanRead_Locked())
@@ -448,7 +448,7 @@ bool AudioRendererImpl::CanRead_Locked() {
void AudioRendererImpl::SetPlaybackRate(float playback_rate) {
DVLOG(1) << __FUNCTION__ << "(" << playback_rate << ")";
- DCHECK(message_loop_->BelongsToCurrentThread());
+ DCHECK(task_runner_->BelongsToCurrentThread());
DCHECK_GE(playback_rate, 0);
DCHECK(sink_);
@@ -533,7 +533,7 @@ int AudioRendererImpl::Render(AudioBus* audio_bus,
}
if (CanRead_Locked()) {
- message_loop_->PostTask(FROM_HERE, base::Bind(
+ task_runner_->PostTask(FROM_HERE, base::Bind(
&AudioRendererImpl::AttemptRead, weak_this_));
}

Powered by Google App Engine
This is Rietveld 408576698