Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 6580058: NSS: Unlock crypto devices when populating cert manager. (Closed)

Created:
6 years, 8 months ago by mattm
Modified:
6 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

NSS: Unlock crypto devices when populating cert manager. BUG=42073 TEST=try to use cert manager with "unfriendly" device. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77024

Patch Set 1 #

Patch Set 2 : missing newline #

Total comments: 18

Patch Set 3 : rebase #

Patch Set 4 : review changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -43 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/ui/crypto_module_password_dialog.h View 1 2 3 4 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/crypto_module_password_dialog_nss.cc View 1 2 3 6 chunks +44 lines, -26 lines 0 comments Download
M chrome/browser/ui/crypto_module_password_dialog_openssl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/crypto_module_password_dialog.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/certificate_manager_model.h View 1 2 3 2 chunks +8 lines, -3 lines 0 comments Download
M content/browser/certificate_manager_model.cc View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M net/base/cert_database.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/base/cert_database_nss.cc View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M net/base/cert_database_openssl.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mattm
With this I'm able to view certs on an Aladdin eToken Pro. Exporting fails but ...
6 years, 8 months ago (2011-02-25 03:48:07 UTC) #1
wtc
LGTM. I have some comments and suggested changes below. Also note the comment marked with ...
6 years, 8 months ago (2011-03-02 03:33:28 UTC) #2
mattm
http://codereview.chromium.org/6580058/diff/1012/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/6580058/diff/1012/chrome/app/generated_resources.grd#newcode6383 chrome/app/generated_resources.grd:6383: <message name="IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_CERT_MANAGER" desc="The text in the dialog that prompts ...
6 years, 8 months ago (2011-03-05 02:16:32 UTC) #3
wtc
6 years, 8 months ago (2011-03-08 19:51:48 UTC) #4
LGTM!

http://codereview.chromium.org/6580058/diff/11001/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/6580058/diff/11001/chrome/app/generated_resour...
chrome/app/generated_resources.grd:6439: <message
name="IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_LIST_CERTS" desc="The text in the
dialog that prompts for security device password when using the certificate
manager without taking a specific action (eg, just loading the cert manager).">
Nit: since the name of the message has changed to say
"LIST_CERTS", the description of the message should be updated
to say "listing certificates" instead of "loading the
cert manager".

Powered by Google App Engine
This is Rietveld efc10ee0f