Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 658003004: Rebaseline plugin tests for changed NPP_Destroy message. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Rebaseline plugin tests for changed NPP_Destroy message. https://codereview.chromium.org/659023002/ fixes the test plugin to flush stdout after logging messages to it to ensure that the output appears. Unfortunately, Windows still doesn't want to display the test logging. BUG=363099, 371084 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183997

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : With results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/plugins/geturlnotify-during-document-teardown-expected.txt View 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/nested-plugin-objects-expected.txt View 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/netscape-destroy-plugin-script-objects-expected.txt View 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/open-and-close-window-with-plugin-expected.txt View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
Here's the new baselines.
6 years, 2 months ago (2014-10-16 08:42:02 UTC) #2
Mike West
On 2014/10/16 08:42:02, dcheng wrote: > Here's the new baselines. Can you add a link ...
6 years, 2 months ago (2014-10-16 08:44:01 UTC) #3
dcheng
On 2014/10/16 at 08:44:01, mkwst wrote: > On 2014/10/16 08:42:02, dcheng wrote: > > Here's ...
6 years, 2 months ago (2014-10-16 08:47:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658003004/1
6 years, 2 months ago (2014-10-16 09:18:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/32042)
6 years, 2 months ago (2014-10-16 11:23:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658003004/40001
6 years, 2 months ago (2014-10-20 16:08:14 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 17:08:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183997

Powered by Google App Engine
This is Rietveld 408576698