Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 657953003: Use version macros for SSL versions. (Closed)

Created:
6 years, 2 months ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use version macros for SSL versions. We only support building with our bundled SSL implementations, so there's no need to be conservative about constants. BUG=none Committed: https://crrev.com/1d094026bf5b8d8a9639b2d2942223b88fe0e576 Cr-Commit-Position: refs/heads/master@{#302840}

Patch Set 1 #

Patch Set 2 : also on the OpenSSL side #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M net/socket/ssl_client_socket_nss.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
davidben
Completely unimportant cosmetic thing.
6 years, 1 month ago (2014-11-05 00:37:45 UTC) #2
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-11-05 05:16:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657953003/20001
6 years, 1 month ago (2014-11-05 05:17:11 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
6 years, 1 month ago (2014-11-05 06:18:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657953003/40001
6 years, 1 month ago (2014-11-05 18:00:46 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-05 18:55:54 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 18:56:34 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1d094026bf5b8d8a9639b2d2942223b88fe0e576
Cr-Commit-Position: refs/heads/master@{#302840}

Powered by Google App Engine
This is Rietveld 408576698