Issue 657933002: [NaCl SDK] nacl_io: getsockname() should return non-zero port after bind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 657933002: [NaCl SDK] nacl_io: getsockname() should return non-zero port after bind. (Closed)

Created:
6 years, 2 months ago by binji

Modified:
6 years, 2 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[NaCl SDK] nacl_io: getsockname() should return non-zero port after bind. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3963 R=noelallen@chromium.org Committed: https://crrev.com/e53a64ea98335d39d00fc1ea1f32e86cd5a624cb Cr-Commit-Position: refs/heads/master@{#299774}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

binji

Committed patchset #1 (id:1) manually as e53a64ea98335d39d00fc1ea1f32e86cd5a624cb (presubmit successful).

6 years, 2 months ago (2014-10-15 21:43:36 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-10-15 21:43:37 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e53a64ea98335d39d00fc1ea1f32e86cd5a624cb
Cr-Commit-Position: refs/heads/master@{#299774}