Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: ppapi/tests/test_case.html

Issue 65793002: PPAPI/NaCl: Make tests enforce dispatchEvent check (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_case.html
diff --git a/ppapi/tests/test_case.html b/ppapi/tests/test_case.html
index 1552ae2a5e063026f29d887dd3a24d63229b3d19..12053bce5f19104de6c0ed26b3b4e98c3be34cd2 100644
--- a/ppapi/tests/test_case.html
+++ b/ppapi/tests/test_case.html
@@ -297,14 +297,7 @@ onload = function() {
// below.
var original = obj.dispatchEvent;
obj.dispatchEvent = function() {
- // TODO(dmichael): NaCl triggers this; take out the special case for NaCl
- // when crbug.com/109775 is fixed.
- if (mode.indexOf("nacl") !== 0)
- InternalError("Bad dispatchEvent called!");
-
- // Pass it on anyways, we need the event to detect load progress and
- // errors.
- return original.apply(obj, arguments);
+ InternalError("Bad dispatchEvent called!");
}
container.appendChild(obj);
}
@@ -314,10 +307,9 @@ onload = function() {
// This part of the script does some nefarious things to make sure that it
// doesn't affect the behavior of PostMessage (on which all the tests rely). In
// particular, we replace document.createEvent, MessageEvent.initMessageEvent,
-// and the MessageEvent constructor. Previous versions of the PostMessage
-// implementation made use of these and would fail (http://crbug.com/82604).
-// The NaCl plugin uses dispatchEvent for progress events, hence we are careful
-// to make that still pass for NaCl (see above, and see crbug.com/109775).
+// and the MessageEvent constructor. Previously, the NaCl integration
+// implementation made use of these and would fail (http://crbug.com/82604
+// and http://crbug.com/109775).
document.createEvent = function() {
InternalError("Bad document.createEvent called!");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698