Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 65793002: PPAPI/NaCl: Make tests enforce dispatchEvent check (Closed)

Created:
7 years, 1 month ago by dmichael (off chromium)
Modified:
7 years, 1 month ago
Reviewers:
bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

PPAPI/NaCl: Make tests enforce dispatchEvent check Bug 109775 was fixed by https://src.chromium.org/viewvc/chrome?view=rev&revision=233356 So now I can give the tests some teeth for NaCl to make sure we don't regress on issue 109775. I tested this locally with and without rev 233356 to make sure that the test would fail without that fix. BUG=109775 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234069

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M ppapi/tests/test_case.html View 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmichael (off chromium)
7 years, 1 month ago (2013-11-08 18:48:46 UTC) #1
bbudge
lgtm
7 years, 1 month ago (2013-11-08 19:13:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/65793002/1
7 years, 1 month ago (2013-11-08 19:28:02 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-08 19:49:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/65793002/310001
7 years, 1 month ago (2013-11-08 20:35:28 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 01:37:33 UTC) #6
Message was sent while issue was closed.
Change committed as 234069

Powered by Google App Engine
This is Rietveld 408576698