Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 657923003: Owner is allowed as a secondary user. chrome://settings honors profile now. (Closed)

Created:
6 years, 1 month ago by ygorshenin1
Modified:
6 years, 1 month ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Owner is allowed as a secondary user. chrome://settings honors profile now. BUG=230018 TEST=manual tests on falco Committed: https://crrev.com/3d1230ea54df41e33938c61e9e755e7a6650a9db Cr-Commit-Position: refs/heads/master@{#301410}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/browser/chromeos/login/users/multi_profile_user_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 2 chunks +10 lines, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
ygorshenin1
6 years, 1 month ago (2014-10-27 15:56:10 UTC) #2
Nikita (slow)
lgtm https://codereview.chromium.org/657923003/diff/1/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc File chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc (right): https://codereview.chromium.org/657923003/diff/1/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc#newcode235 chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:235: CrosSettings::Get()->Set(pref_name, *value); Which settings still go through CrosSettings?
6 years, 1 month ago (2014-10-27 16:44:38 UTC) #3
ygorshenin1
https://codereview.chromium.org/657923003/diff/1/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc File chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc (right): https://codereview.chromium.org/657923003/diff/1/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc#newcode235 chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:235: CrosSettings::Get()->Set(pref_name, *value); On 2014/10/27 16:44:38, Nikita Kostylev wrote: > ...
6 years, 1 month ago (2014-10-27 18:29:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657923003/1
6 years, 1 month ago (2014-10-27 18:31:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 19:32:58 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:33:41 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3d1230ea54df41e33938c61e9e755e7a6650a9db
Cr-Commit-Position: refs/heads/master@{#301410}

Powered by Google App Engine
This is Rietveld 408576698