Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 657903004: Accessible scrollToMakeVisible should avoid scrolling if subfocus is visible. (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
aboxhall
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Accessible scrollToMakeVisible should avoid scrolling if subfocus is visible. The code already avoided scrolling if an object was already visible. This extends that logic so that if the object is larger than the viewport, it avoids scrolling if the subfocus is already visible. BUG=374316, 424691 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183932

Patch Set 1 #

Patch Set 2 : Proper upstream #

Patch Set 3 : Update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M LayoutTests/accessibility/scroll-to-make-visible-nested-2.html View 1 3 chunks +26 lines, -8 lines 0 comments Download
M LayoutTests/accessibility/scroll-to-make-visible-nested-2-expected.txt View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/accessibility/AXObject.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dmazzoni
Depends on: https://codereview.chromium.org/661183002/ Minor tweak to that change to make it a bit better.
6 years, 2 months ago (2014-10-17 21:35:27 UTC) #2
aboxhall
lgtm
6 years, 2 months ago (2014-10-17 21:49:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657903004/40001
6 years, 2 months ago (2014-10-17 21:56:00 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 23:16:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183932

Powered by Google App Engine
This is Rietveld 408576698