Issue 6579023: Added PPB_GLESChromiumTextureMapping interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6579023: Added PPB_GLESChromiumTextureMapping interface. (Closed)

Created:
9 years, 10 months ago by neb

Modified:
9 years, 7 months ago

Reviewers:
nfullagar

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

Description

Added PPB_GLESChromiumTextureMapping interface. BUG=none TEST=The interface and GL extension described should be available to nexes.

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -0 lines)			Patch
M	src/shared/ppapi_proxy/nacl.scons	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/shared/ppapi_proxy/plugin_ppb.cc	View	2 chunks	+3 lines, -0 lines	1 comment	Download
A	src/shared/ppapi_proxy/plugin_ppb_gles_extensions.h	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	src/shared/ppapi_proxy/plugin_ppb_gles_extensions.cc	View	1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nfullagar

one Q... http://codereview.chromium.org/6579023/diff/1/src/shared/ppapi_proxy/plugin_ppb.cc File src/shared/ppapi_proxy/plugin_ppb.cc (right): http://codereview.chromium.org/6579023/diff/1/src/shared/ppapi_proxy/plugin_ppb.cc#newcode44 src/shared/ppapi_proxy/plugin_ppb.cc:44: GLESChromiumTextureMapping::GetInterface(), true }, hmm... we're going to ...

9 years, 10 months ago (2011-02-24 02:07:51 UTC) #2

neb

9 years, 10 months ago (2011-02-24 03:55:34 UTC) #3

On 2011/02/24 02:07:51, nfullagar wrote:
> one Q...
> 
>
http://codereview.chromium.org/6579023/diff/1/src/shared/ppapi_proxy/plugin_p...
> File src/shared/ppapi_proxy/plugin_ppb.cc (right):
> 
>
http://codereview.chromium.org/6579023/diff/1/src/shared/ppapi_proxy/plugin_p...
> src/shared/ppapi_proxy/plugin_ppb.cc:44:
> GLESChromiumTextureMapping::GetInterface(), true },
> hmm... we're going to do each block of gl extensions as a separate PPAPI
> interface?

That's still up in the air. But this interface already exists in PPAPI so I
reckon we should proxy it.

Expand Messages | Collapse Messages