sandbox/linux/bpf_dsl/policy_compiler.cc - Issue 657893006: SyscallSet: add ValidOnly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/bpf_dsl/policy_compiler.cc

Issue 657893006: SyscallSet: add ValidOnly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/bpf_dsl/policy_compiler.cc

diff --git a/sandbox/linux/bpf_dsl/policy_compiler.cc b/sandbox/linux/bpf_dsl/policy_compiler.cc

index 0eb85ca6736bb3662dbf520b13d7723e7c2cc3d8..995a3902d03766539e4a23e03c33a97eb8468d88 100644

--- a/sandbox/linux/bpf_dsl/policy_compiler.cc

+++ b/sandbox/linux/bpf_dsl/policy_compiler.cc

@@ -76,9 +76,8 @@ intptr_t BPFFailure(const struct arch_seccomp_data&, void* aux) {

}

bool HasUnsafeTraps(const SandboxBPFDSLPolicy* policy) {

- for (uint32_t sysnum : SyscallSet::All()) {

- if (SyscallSet::IsValid(sysnum) &&

- policy->EvaluateSyscall(sysnum)->HasUnsafeTraps()) {

+ for (uint32_t sysnum : SyscallSet::ValidOnly()) {

+ if (policy->EvaluateSyscall(sysnum)->HasUnsafeTraps()) {

return true;

}