SyscallSet: add ValidOnly

SyscallSet: add ValidOnly

BUG=414363
TBR=jln@chromium.org

Committed: https://crrev.com/8340278f00dfeda41c6a36453277aeec1f0048f2
Cr-Commit-Position: refs/heads/master@{#301513}

[mdempsky, 2014-10-23 18:57:18]

mdempsky@chromium.org changed reviewers:
+ jln@chromium.org, rickyz@chromium.org

[rickyz (no longer on Chrome), 2014-10-24 20:17:17]

lgtm

https://codereview.chromium.org/657893006/diff/1/sandbox/linux/seccomp-bpf/sy...
File sandbox/linux/seccomp-bpf/syscall_iterator.cc (right):

https://codereview.chromium.org/657893006/diff/1/sandbox/linux/seccomp-bpf/sy...
sandbox/linux/seccomp-bpf/syscall_iterator.cc:68: ++*this;
This took me a little bit to wrap my head around - might be good to have a
comment like:

// Skip to the first syscall in the requested set.

https://codereview.chromium.org/657893006/diff/1/sandbox/linux/seccomp-bpf/sy...
sandbox/linux/seccomp-bpf/syscall_iterator.cc:95: if (want_invalid &&
range.first > 0 && num_ < range.first - 1) {
Might be good to comment that we're intentionally skipping over most of the
invalid range here - I was a little confused until I saw the comment in the
header.

[mdempsky, 2014-10-24 21:49:56]

PTAL

https://codereview.chromium.org/657893006/diff/1/sandbox/linux/seccomp-bpf/sy...
File sandbox/linux/seccomp-bpf/syscall_iterator.cc (right):

https://codereview.chromium.org/657893006/diff/1/sandbox/linux/seccomp-bpf/sy...
sandbox/linux/seccomp-bpf/syscall_iterator.cc:68: ++*this;
On 2014/10/24 20:17:16, rickyz wrote:
> This took me a little bit to wrap my head around - might be good to have a
> comment like:
> 
> // Skip to the first syscall in the requested set.

Done.

https://codereview.chromium.org/657893006/diff/1/sandbox/linux/seccomp-bpf/sy...
sandbox/linux/seccomp-bpf/syscall_iterator.cc:95: if (want_invalid &&
range.first > 0 && num_ < range.first - 1) {
On 2014/10/24 20:17:17, rickyz wrote:
> Might be good to comment that we're intentionally skipping over most of the
> invalid range here - I was a little confused until I saw the comment in the
> header.

Done.

[mdempsky, 2014-10-27 22:01:00]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-10-27 22:02:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657893006/20001

[commit-bot: I haz the power, 2014-10-27 22:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-27 22:13:01]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/74236)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[mdempsky, 2014-10-27 22:31:25]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-10-27 22:37:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657893006/40001

[commit-bot: I haz the power, 2014-10-28 00:26:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-28 00:27:20]

Patchset 3 (id:??) landed as
https://crrev.com/8340278f00dfeda41c6a36453277aeec1f0048f2
Cr-Commit-Position: refs/heads/master@{#301513}