Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 657863005: Allow index sources to be unpremul. (Closed)

Created:
6 years, 2 months ago by scroggo
Modified:
6 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Allow index sources to be unpremul. This only affects the PNG image decoder, where we have already created the color table without premultiplication. Since the RowProcChooser is just providing a proc that chooses indices into the color table, it can just return the same RowProc. Update test_row_proc_choice. It was testing to ensure that we hadn't changed the behavior from the original version of setPrefConfigTable. In this case, we deliberately changed the behavior, so we need to change the test. BUG=b/12024301 Committed: https://skia.googlesource.com/skia/+/13f701a14d2a303b153ea861a3482e25254a9c3c

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/premultiplication/opts.fPremultiplyAlpha #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/images/SkScaledBitmapSampler.cpp View 1 2 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
scroggo
6 years, 2 months ago (2014-10-23 21:50:18 UTC) #2
reed1
lgtm w/ nit https://codereview.chromium.org/657863005/diff/1/src/images/SkScaledBitmapSampler.cpp File src/images/SkScaledBitmapSampler.cpp (right): https://codereview.chromium.org/657863005/diff/1/src/images/SkScaledBitmapSampler.cpp#newcode400 src/images/SkScaledBitmapSampler.cpp:400: // properly with respect to premultiplication, ...
6 years, 2 months ago (2014-10-24 14:28:54 UTC) #3
scroggo
https://codereview.chromium.org/657863005/diff/1/src/images/SkScaledBitmapSampler.cpp File src/images/SkScaledBitmapSampler.cpp (right): https://codereview.chromium.org/657863005/diff/1/src/images/SkScaledBitmapSampler.cpp#newcode400 src/images/SkScaledBitmapSampler.cpp:400: // properly with respect to premultiplication, so premul makes ...
6 years, 1 month ago (2014-10-27 15:07:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657863005/20001
6 years, 1 month ago (2014-10-27 15:08:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/274)
6 years, 1 month ago (2014-10-27 15:24:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657863005/40001
6 years, 1 month ago (2014-10-27 15:35:48 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 15:43:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 13f701a14d2a303b153ea861a3482e25254a9c3c

Powered by Google App Engine
This is Rietveld 408576698