Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 657863004: Deterministic recipe: Change the target to chrome_run (Closed)

Created:
6 years, 2 months ago by Sébastien Marchand
Modified:
6 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Deterministic recipe: Change the target to chrome_run BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292637

Patch Set 1 #

Messages

Total messages: 10 (4 generated)
Sébastien Marchand
PTAL. (I'll land this once https://codereview.chromium.org/666143004/ has been committed)
6 years, 2 months ago (2014-10-23 21:29:55 UTC) #2
M-A Ruel
lgtm
6 years, 2 months ago (2014-10-23 21:36:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657863004/1
6 years, 2 months ago (2014-10-23 23:02:50 UTC) #5
commit-bot: I haz the power
Presubmit check for 657863004-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 2 months ago (2014-10-23 23:04:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657863004/1
6 years, 2 months ago (2014-10-23 23:54:25 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:55:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292637

Powered by Google App Engine
This is Rietveld 408576698