Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 657863003: Add Sky to the build system (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove non-existent target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
6 years, 2 months ago (2014-10-23 18:21:12 UTC) #2
abarth-chromium
6 years, 2 months ago (2014-10-23 18:29:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c08779c3f8ec4af1f5a61076a913970e91fef634 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698